fix PhOpenDriver regression from 95bc2fe #2322
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DartVanya
changed the title
|
I'll partial revert the commit and merge with some other changes 👍 |
Ok, thanks. And I think there is a missing line, because now SI crashes if warnings are enabled and you try to start a service (context->Object null pointer dereference).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Directory and Driver objects cannot be opened with OBJ_EXCLUSIVE, system calls returns STATUS_INVALID_PARAMETER even currently is zero opened handles for this object. This breaks both PhOpenDriver and PhOpenDriverByBaseAddress.
95bc2fe#diff-7b1df2858b7dc31ac554743937d5e518d03d6957113a83969968d4b1626096c1R5621